Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS type errors due to upgrade to ts_rs 10.0.0 #3938

Closed
wants to merge 3 commits into from
Closed

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Sep 20, 2024

Copy link

qa-wolf bot commented Sep 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 20, 2024 7:01pm

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is happy, I'm happy!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (93d9b10) to head (fc64004).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3938   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          69       69           
  Lines       25121    25121           
=======================================
  Hits        21894    21894           
  Misses       3227     3227           
Flag Coverage Δ
wasm-lib 87.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtran
Copy link
Collaborator Author

jtran commented Sep 20, 2024

Merged via #3931.

@jtran jtran closed this Sep 20, 2024
auto-merge was automatically disabled September 20, 2024 21:30

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants